They have to be "successful" to gain a skill, so if they have no building skill, it's like trying to teach them the first time...it might take 4 or 5 tries to get the skill increase.

Maybe it's just me, but I've only had villagers gain building skill if they carry the boulder: the ones that go running or swimming never seem to gain skill. But maybe I missed something...

Just keep trying, I guess